Skip to content

Avoid generating wrong enum assertions produced by engine bug #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Avoid generating wrong enum assertions produced by engine bug #1706

merged 1 commit into from
Jan 18, 2023

Conversation

sofurihafe
Copy link
Member

Description

There are cases when we generate false assertion for enums. Refer to the issue no. 1704

Fixes # (1672)

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Automated Testing

utbot-samples.

Manual Scenario

Use the following estimator settings:

timeLimit = 160
methodFilter = "com.google.common.base.CaseFormat.*"
projectFilter = listOf("guava-26.0")

Verify that, for example, testDoBackward2 method in the generated file does not have an assertion for initial and final fields.

@EgorkaKulikov EgorkaKulikov changed the title Avoid generating enum assertions Avoid generating wrong enum assertions produced by engine bug Jan 18, 2023
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) January 18, 2023 14:38
@EgorkaKulikov EgorkaKulikov merged commit 85fa0ba into main Jan 18, 2023
@EgorkaKulikov EgorkaKulikov deleted the andrey-t/hack_enum_field_assertions branch January 18, 2023 14:42
@sofurihafe sofurihafe linked an issue Jan 20, 2023 that may be closed by this pull request
Failing Assertions in tests on guava-26.0 generated by Contest Estimator #1672
Closed
@alisevych alisevych added comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug labels Jan 23, 2023
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug
Projects
None yet
Milestone
2023.3 Release
Development

Successfully merging this pull request may close these issues.

Failing Assertions in tests on guava-26.0 generated by Contest Estimator
3 participants
@sofurihafe @EgorkaKulikov @alisevych