Consider containingClass when matching psi methods and KFuncitons #1398 #1502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To get
ExecutableIds of methods selected in plugin, we have to somehow match psi methods with reflections of the corresponding loaded methods. Previously we did matching bySignature, but it was not sufficient, e.g. abstract method and its implementation would have the sameSignature. This PR replacesSignaturewithMethodDescriptionwhich includes signature, but also hascontainingClassparameter.Fixes #1398
Type of Change
How Has This Been Tested?
Manual Scenario
Tested on the example from #1398 -- now the tests class with tests is generated for
PointChecklist (remove irrelevant options):
This is the author self-check list