Avoid presence of our internal types in generated code #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaelmBleidd
changed the title
Damtev
requested changes
Oct 27, 2022
utbot-framework/src/main/kotlin/org/utbot/engine/DataClasses.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/DataClasses.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/util/SootUtils.kt
Outdated
Show resolved
Hide resolved
CaelmBleidd
force-pushed
the
caelmbleidd/remove_non_user_classes_from_hierarchy
branch
from
c5bb35d to
05ce652
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/remove_non_user_classes_from_hierarchy
branch
from
6c42795 to
6424db6
Compare
Damtev
requested changes
Oct 27, 2022
utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
Outdated
Show resolved
Hide resolved
CaelmBleidd
force-pushed
the
caelmbleidd/remove_non_user_classes_from_hierarchy
branch
from
6424db6 to
72d51f9
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/remove_non_user_classes_from_hierarchy
branch
from
72d51f9 to
32319e2
Compare
Damtev
approved these changes
Oct 27, 2022
CaelmBleidd
deleted the
caelmbleidd/remove_non_user_classes_from_hierarchy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This request remove soot types and our internal types from soot classes at all, and our classes used for mocks, overrides, etc., from the construction of type storages. At the same time, it changes API for
TypeStorageclass to avoid misunderstanding of what types will it contains after its creation via different constructors.Fixes #295
Type of Change
How Has This Been Tested?
Automated Testing
There was no specific tests added. This request should not break already existed as a proof that we didn't remove anything that was required by our overridden classes.
Manual Scenario
There was no manual testing.
Checklist: