Repository navigation
Mock for dependent list is created but not injected into entity #2637
Description
Description
linkedListSpy is created and configured, but not injected into Entity under test
To Reproduce
- Install -IU- UnitTestBot plugin in IntelliJ IDEA
- Open
spring-petclinic - Generate
Unit testsforOwnerwithPetClinicApplicationconfiguration - Run the tests
Expected behavior
No NPE should be thrown from get-methods of the entity before assertions.
Actual behavior
There are several tests throwing NPE when getting fields of actual Pet.
Screenshots, logs
@Test
@DisplayName("getPet: id = zero (mutated from min)")
public void testGetPetWithCornerCase5() throws ClassNotFoundException, IllegalAccessException, NoSuchFieldException, InvocationTargetException, NoSuchMethodException {
owner.setLastName("-3");
Pet petMock = mock(Pet.class);
(when(petMock.isNew())).thenReturn(true);
linkedListSpy.add(petMock);
Pet petMock1 = mock(Pet.class);
(when(petMock1.isNew())).thenReturn(false);
(when(petMock1.getId())).thenReturn(0);
linkedListSpy.add(petMock1);
Pet petMock2 = mock(Pet.class);
linkedListSpy.add(petMock2);
Pet petMock3 = mock(Pet.class);
linkedListSpy.add(petMock3);
Pet petMock4 = mock(Pet.class);
linkedListSpy.add(petMock4);
Pet actual = owner.getPet(0);
LocalDate actualBirthDate = actual.getBirthDate();
assertNull(actualBirthDate);
PetType actualType = actual.getType();
assertNull(actualType);
Set actualVisits = ((Set) getFieldValue(actual, "org.springframework.samples.petclinic.owner.Pet", "visits"));
assertNull(actualVisits);
String actualName = actual.getName();
assertNull(actualName);
Integer actualId = actual.getId();
assertNull(actualId);
}
Environment
IntelliJ IDEA version - Community 2023.2
Project - Maven
JDK - 17
Additional context
When debugging, linkedListSpy is returning expected values.
There is pet returning isNew()=false and getId()=0.
But owner.getPets() returns empty list.
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
EgorkaKulikov commentedon Oct 3, 2023
Investigated with @tepa46 and @Vassiliy-Kudryashov - looks like a very strange case.
There is no obvious reasons why Spring cannot inject this Spy into the instance under test. It can be manually fixed if we replace
ArrayListwithArrayList<Pet>, but we cannot generate such code due to generics support limitations in UnitTestBot.Tomorrow I'm going to ask other collegues if they see the reasons of autowiring problems here. If we clarify it, it may be possible to use some fallback as we do when there are several lists of one type in project.
EgorkaKulikov commentedon Oct 4, 2023
It seems to be a bug in Mockito.
Consider the following test
This version does not work
This version works
However, in accordance with
@Spydocumentation, it must be the same.Seems to be a generics support problems in
@InjectMocks. There are some other known issues about it, like mockito/mockito#1066.alisevych commentedon Oct 4, 2023
@EgorkaKulikov
Can we generate code like it is in your second example?
With explicit spy creation?
EgorkaKulikov commentedon Oct 4, 2023
@SPY annotation was constructed as a smart syntax and guidelines recommend it. After that, here we know one seldom bug, I have no idea how many potential problems are hidden in it. It can be investigated, but it will take time.