Not support anonymous union in struct #317 #391
Conversation
- better tests for union printer - less divergent between struct and union
| using namespace std::chrono_literals; | ||
| while (holdLockFlag[callbackName].exchange(true, std::memory_order_acquire)) { | ||
| std::this_thread::yield(); | ||
| std::this_thread::sleep_for(100ms); |
There was a problem hiding this comment.
[PERF] UTBot consumes CPU in spinlocks #382
| const types::Type &type, | ||
| size_t offset, | ||
| size_t len); | ||
| static std::shared_ptr<EnumValueView> enumView(const std::vector<char> &byteArray, |
There was a problem hiding this comment.
Group enum and struct-like. Seems they need to be joined in the future.
| strFunctionCall(PrinterUtils::KLEE_PREFER_CEX, { state.paramName, cons }); | ||
| } else { | ||
| ss << TAB_N() << "// No constraints for " << state.curElement << NL; | ||
| ss << LINE_INDENT() << "// No constraints for " << state.curElement << NL; |
There was a problem hiding this comment.
Indent can include the inline comment, so rename it to indent.
| ConstraintsState newState = { state.paramName, | ||
| access, | ||
| field.type, | ||
| isStruct ? state.endString : false, |
There was a problem hiding this comment.
That is still essential difference between struct and union. Need to be investigated (in progress).
| case TypeKind::OBJECT_POINTER: | ||
| if (types::TypesHandler::isArrayOfPointersToFunction(field.type)) { | ||
| genStubForStructFunctionPointerArray(state.curElement, field.name, stubFunctionName); | ||
| genStubForStructFunctionPointerArray(state.curElement, field, |
There was a problem hiding this comment.
no more just by name access. That leads to unpredictable errors.
server/src/printers/TestsPrinter.cpp
Outdated
| structuredValuesWithPrefixes << "{" << NL; | ||
| ++printer->tabsDepth; | ||
|
|
||
| int longestFieldIndexForUnionInit = view->getLongestFieldIndexForUnionInit(); |
There was a problem hiding this comment.
So now we are printing all the fields in union, but commenting all, except the longest.
| return getTypeKind(type) == TypeKind::UNKNOWN; | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
the subject of bugfix.
| }); | ||
| }; | ||
|
|
||
| if (isUnion(type)) { |
There was a problem hiding this comment.
Has no direct influence to the tests
| return false; | ||
| }); | ||
| }; | ||
| if (isStruct(type)) { |
There was a problem hiding this comment.
Has no direct influence to the tests
| std::string types::EnumInfo::getEntryName(const std::string &value, utbot::Language language) { | ||
| auto const& entry = valuesToEntries[value]; | ||
| std::string types::EnumInfo::getEntryName(const std::string &value, utbot::Language language) const { | ||
| const EnumEntry &entry = valuesToEntries.at(value); |
There was a problem hiding this comment.
Has no const operator[], so changed.
- fix for Syntax_Test.Union_With_Pointer_Test
server/src/Tests.cpp
Outdated
| : AbstractValueView(std::move(subViews)), | ||
| entryValue(PrinterUtils::convertBytesToUnion(typeName, rawDataView->getEntryValue(nullptr))) { | ||
| } | ||
| //UnionValueView::UnionValueView( |
server/src/printers/TestsPrinter.cpp
Outdated
| structuredValuesWithPrefixes << printer->LINE_INDENT() << view->getFieldPrefix(i) | ||
| << sview->getEntryValue(printer); | ||
| } | ||
| else { |
server/src/types/Types.h
Outdated
| struct StructInfo: TypeInfo { | ||
| std::vector<Field> fields{}; | ||
|
|
||
| int longestFieldIndexForUnionInit; |
server/src/types/Types.h
Outdated
| */ | ||
| UnionInfo getUnionInfo(const Type&) const; | ||
|
|
||
| bool isStruct(uint64_t id) const; |
No description provided.