Skip to content

feat: add Magic Connect connector to readme#789

Closed
ZYJLiu wants to merge 1 commit intoUniswap:mainfrom
Unboxed-Software:main
Closed

feat: add Magic Connect connector to readme#789
ZYJLiu wants to merge 1 commit intoUniswap:mainfrom
Unboxed-Software:main

Conversation

@ZYJLiu
Copy link

@ZYJLiu ZYJLiu commented Mar 31, 2023

Feature

Adds support for Magic Connect, which allows instant non-custodial wallets with a simple UX. Magic is used by over 110k developers who have created over 20M wallets. Given its widespread use, it makes sense to have a Magic connector that integrates with web3-react.

  • The Magic Connect connector is maintained here
  • A basic Next.js example of its usage here

Usage

import { initializeConnector } from "@web3-react/core"
import { MagicConnect } from "web3-react-magic"

export const [magicConnect, hooks] = initializeConnector<MagicConnect>(
  (actions) =>
    new MagicConnect({
      actions,
      options: {
        apiKey: process.env.NEXT_PUBLIC_MAGICKEY, // Magic Connect Publishable API key
        networkOptions: {
          rpcUrl: process.env.NEXT_PUBLIC_GOERLI_RPC, // RPC URL
          chainId: 5, // Chain ID for network
        },
      },
    })
)

magic

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 10:47PM (UTC)

@grabbou
Copy link
Contributor

grabbou commented Apr 5, 2023

Hey!

Thanks for the PR! So far, we've been endorsing official external packages. Have you been in touch with MagicLink team regarding your plugin development? Good first step would be to get it endorsed by Magic team and have listed on their documentation too.

Also, please let me know what is your current userbase and roadmap, if any.

I am going to close the PR in the meantime, but let's continue having discussion.

@grabbou grabbou added the blocked label Apr 5, 2023
@grabbou grabbou closed this Apr 5, 2023
@jamesrp13
Copy link

Hey @grabbou thanks for the comment! We've actually been in touch with the Magic team while creating this. They've reviewed the code and are excited about getting Magic support integrated into web3-react. I can definitely reach out to them to talk about including the connector in their documentation. Is there anything else we can do that would help in the approval process here?

@ZYJLiu
Copy link
Author

ZYJLiu commented May 4, 2023

@grabbou The connector is now listed on the magic docs under resources here. Are there any additional steps required before getting the connector added in the readme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants