Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring back walletconnect v1 #773

Merged
merged 9 commits into from
Mar 3, 2023
Merged

feat: bring back walletconnect v1 #773

merged 9 commits into from
Mar 3, 2023

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Feb 28, 2023

Initially, we deprecated WalletConnect V1 and replaced it immediately with V2. We have made decision internally that we're going to ship both packages side by side till V1 is deprecated, instead of bumping major version and cutting legacy branch. This PR brings back V1.

Changelog:

  • dropping peer dependencies in favour of dependencies so both WC can run side by side
  • added @walletconnect/types dependency that was missing before inside walletconnect (v1) package
  • bumped version locally to latest published to npm (which is currently v2), next publish will bring downgrade @web3-react/walletconnect back to v1

Screenshot 2023-02-28 at 20 12 14

PS. I did git mv to move walletConnectCard.tsx to walletConnectV2Card.tsx but unfortunately, that didn't help with the diff - it still reports that I did changes in place and created a new walletConnectV2Card.tsx, which is not really what happened.

@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 5:47PM (UTC)

Copy link
Contributor

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits, but I would like to see the todo updated to be more explicit about why loose is necessary.

example/components/ProviderExample.tsx Show resolved Hide resolved
example/next.config.js Outdated Show resolved Hide resolved
example/components/connectorCards/WalletConnectV2Card.tsx Outdated Show resolved Hide resolved
@grabbou
Copy link
Contributor Author

grabbou commented Mar 3, 2023

Thanks for the review @zzmp! I do agree with you on the loose workaround and I am waiting for further context before making it more explicit and then, merging this PR!

Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
@grabbou
Copy link
Contributor Author

grabbou commented Mar 3, 2023

Unit test failure due to network failure, unrelated.

@grabbou grabbou merged commit b97f6be into main Mar 3, 2023
@grabbou grabbou deleted the feat/bring-back-wc-v1 branch March 3, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants