-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring back walletconnect v1 #773
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly nits, but I would like to see the todo updated to be more explicit about why loose
is necessary.
Thanks for the review @zzmp! I do agree with you on the |
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
Unit test failure due to network failure, unrelated. |
Initially, we deprecated WalletConnect V1 and replaced it immediately with V2. We have made decision internally that we're going to ship both packages side by side till V1 is deprecated, instead of bumping major version and cutting legacy branch. This PR brings back V1.
Changelog:
@walletconnect/types
dependency that was missing before insidewalletconnect
(v1) packagenpm
(which is currently v2), next publish will bring downgrade@web3-react/walletconnect
back to v1PS. I did
git mv
to movewalletConnectCard.tsx
towalletConnectV2Card.tsx
but unfortunately, that didn't help with the diff - it still reports that I did changes in place and created a newwalletConnectV2Card.tsx
, which is not really what happened.