Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mint position event #279

Merged
merged 4 commits into from
Aug 5, 2024
Merged

add mint position event #279

merged 4 commits into from
Aug 5, 2024

Conversation

snreynolds
Copy link
Member

while this does add gas, we saved ~30k/40k gas not storing the PositionConfig so we're still net negative with that design change, and this is necessary to inform offchain integrations of a tokenId's associated PositionConfig

made it super minimal (no liquidity param), as anything related to getting liquidity value should be picked up from core events

saucepoint
saucepoint previously approved these changes Aug 5, 2024
Copy link
Collaborator

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and makes sense why we need it


also worth mentioning _modifyLiquidity cannot re-enter posm to mint a position so we wont have out-of-order events 👍

@snreynolds
Copy link
Member Author

looks good and makes sense why we need it

also worth mentioning _modifyLiquidity cannot re-enter posm to mint a position so we wont have out-of-order events 👍

I guess if a hook is the initial caller they could..

@snreynolds snreynolds merged commit af688af into main Aug 5, 2024
3 checks passed
@snreynolds snreynolds deleted the events branch August 5, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants