Recipient mapping! #246
Merged
Recipient mapping! #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
commented
Aug 2, 2024
src/base/BaseActionsRouter.sol
Outdated
| /// @notice Calculates the address for a action | ||
| /// @param recipient The address or address-flag for the action | ||
| /// @return output The resultant address for the action | ||
| function map(address recipient) internal view returns (address) { |
There was a problem hiding this comment.
wouldve been nice in a library but sadly it needs _msgSender to work. Open to suggestions about where the function should live, and where the constants should live
hensha256
commented
Aug 2, 2024
| @@ -0,0 +1 @@ | |||
| 127508 | |||
There was a problem hiding this comment.
Having a recipient of a specific address (not a helper constant) is now ~90 more expensive than before. But taking to the msg.sender is now ~50 cheaper than before.
And most importantly - our sdks will be much easier to write haha
There was a problem hiding this comment.
previously taking to any address: 127419
now taking to specific address: 127508
now taking to msg.sender: 127370
gretzke
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #202
mapping recipients with constants for 2 reasons