Skip to content

Commit

Permalink
remove SafeCallback from BaseHook
Browse files Browse the repository at this point in the history
  • Loading branch information
gretzke committed Feb 3, 2025
1 parent 00f066a commit 6dfbe57
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions src/utils/BaseHook.sol
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@ import {IHooks} from "@uniswap/v4-core/src/interfaces/IHooks.sol";
import {BalanceDelta} from "@uniswap/v4-core/src/types/BalanceDelta.sol";
import {PoolKey} from "@uniswap/v4-core/src/types/PoolKey.sol";
import {BeforeSwapDelta} from "@uniswap/v4-core/src/types/BeforeSwapDelta.sol";
import {SafeCallback} from "../base/SafeCallback.sol";

/// @title Base Hook
/// @notice abstract contract for hook implementations
abstract contract BaseHook is IHooks, SafeCallback {
abstract contract BaseHook is IHooks {
error NotSelf();
error InvalidPool();
error LockFailure();
error HookNotImplemented();

constructor(IPoolManager _manager) SafeCallback(_manager) {
constructor() {
validateHookAddress(this);
}

Expand Down Expand Up @@ -45,16 +44,6 @@ abstract contract BaseHook is IHooks, SafeCallback {
Hooks.validateHookPermissions(_this, getHookPermissions());
}

function _unlockCallback(bytes calldata data) internal virtual override returns (bytes memory) {
(bool success, bytes memory returnData) = address(this).call(data);
if (success) return returnData;
if (returnData.length == 0) revert LockFailure();
// if the call failed, bubble up the reason
assembly ("memory-safe") {
revert(add(returnData, 32), mload(returnData))
}
}

/// @inheritdoc IHooks
function beforeInitialize(address, PoolKey calldata, uint160) external virtual returns (bytes4) {
revert HookNotImplemented();
Expand Down

0 comments on commit 6dfbe57

Please sign in to comment.