Skip to content

Checking input amount when burning #1006

Open
@TAnNbR

Description

@TAnNbR

The input amount must less than the amount that a LP have in a position, it's apparently here's no logic error in the code because LiquidityMath.addLiquidity(a,b) will make sure a>b when a-b due to solidity's OverFlow checking, but if adding a specific checking such as if (inputAmount < position.liquidity) and a clear revert like notEnoughLiquidity is more clear and meaningful instead of reverting by solidity's OverFlow checking.This is my personal opinion, which may not necessarily be correct

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions