Prepare for deploying the contracts and build artifacts to npmjs #62
Conversation
moodysalem
commented
Apr 15, 2020
moodysalem
commented
- Updated waffle to fix the revert error
- solcVersion is now compilerVersion
- added metadata to package json
- for some reason the gas estimates have changed, but i doubt this means anything. the bytecode that compiling produces has not changed.
|
I still recommend #56 be included in the release prep, though it was closed so I assume that means it was discussed and decided against. |
|
yes @MicahZoltu , we (and more importantly our auditors) are more comfortable with ^0.5 than ^0.6, and |
There was a problem hiding this comment.
@moodysalem looks good! the one thing i'm curious about is if this waffle version bump means that we no longer need the overrides hack (https://github.com/Uniswap/uniswap-v2-core/blob/master/test/shared/fixtures.ts#L15), which is used in a few of the test files to fix failures due to gas misestimation
|
Unfortunately we still need it in the pair tests but looks like it's not needed in the fixtures. Since the gas estimates are wrong I went ahead and fixed the two gas tests to check actual gas used EDIT: I take it back, for some reason not specifying overrides in fixtures breaks one of the tests in node v10... but only on the github actions vm. I can't get it to fail with the latest node v10 locally. Going to assume it has something to do with the evm timestamps in that test and just revert the fixtures changes. |
moodysalem
force-pushed
the
prepare-for-npm
branch
from
95ff215 to
840527f
Compare
|
Deployed v1.0.0-beta.0 artifacts to npm |
|
|
Prepare for deploying the contracts and build artifacts to npmjs
