-
Notifications
You must be signed in to change notification settings - Fork 156
docs(flashtestations-sdk): prepare SDK for initial public release wit… #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (11/04/25)3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
0ce1972 to
08515e4
Compare
paranoiacblack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdks/flashtestations-sdk/README.md
Outdated
| ``` | ||
|
|
||
| Code quality is set up for you with `prettier`, `husky`, and `lint-staged`. Adjust the respective fields in `package.json` accordingly. | ||
| Returns an array of supported chain IDs: `[130, 1301, 22444422, 33611633]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have plans to reset/redeploy Unichain Experimental next week and it's unclear if it will be a new chain ID or not (probably will). I note that to say maybe this documentation shouldn't mention the other chain IDs beyond the stable ones like Unichain Sepolia and Unichain Mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I've removed these from the README.
08515e4 to
3c3906e
Compare
…h comprehensive documentation This commit prepares the flashtestations-sdk for its initial public release by: 1. Overhauling documentation and cleaning up the public API surface. 2. Transforming the README from a generic TSDX template into comprehensive SDK documentation including installation instructions, API reference, error handling guide, advanced usage patterns, and practical examples. 3. Unused example files (getBlock.ts and getTransactionReceipt.ts) have been removed In a future commit we will update the version number to 1.0.0 and publish the SDK to npm improving VerificationResult handling rename getFlashtestationTx -> getFlashtestationEvent this name better matches the data that is returned by the function
3c3906e to
a5c0690
Compare
…h comprehensive documentation
This commit prepares the flashtestations-sdk for its initial public release by:
In a future commit we will update the version number to 1.0.0 and publish the SDK to npm
How Has This Been Tested?
Manually
Are there any breaking changes?
Yes, but not in use yet so it's fine
(Optional) Feedback Focus
run
yarn testto ensure tests still pass, and runnpx tsx examples/verifyBlock.tsas well asnpx tsx examples/getFlashtestationTx.tsto make sure those work given the newsrc/index.tsimports work as expected for those examples.