N-06: Early-revert on zero native value for first id in HybridAllocator #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If first token is native, require non-zero msg.value to fail earlier in HybridAllocator instead of relying on The Compact to revert. Update test to assert allocator-level revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
HybridAllocator._actualIdsAndAmounts, if first id is native andmsg.value == 0, revert withInvalidValue(0, 1). This early failure in allocator, rather than letting The Compact revert, provides a clearer error surface.Test updated:
test_allocateAndRegister_revert_zeroNativeTokensAmountnow expects allocator-level revert.