feat: swap component refactor limits #7588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
just-toby
changed the title
tinaszheng
approved these changes
Nov 14, 2023
| @@ -608,8 +608,10 @@ export function Swap({ | |||
| const isDark = useIsDarkMode() | |||
| const isUniswapXDefaultEnabled = useUniswapXDefaultEnabled() | |||
|
|
|||
| const [currentTab, setCurrentTab] = useState<SwapTab>(SwapTab.Swap) | |||
|
|
|||
| const swapElement = ( | |||
There was a problem hiding this comment.
i think we should move SwapElement into its own file
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Passing run #15528 ↗︎
Details:
Review all test suite changes for PR #7588 ↗︎ |
|||||||||||||||
mattbspector
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add feature flag for limits and refactor the swap UI a little bit to allow for the new tab.
Linear ticket:
Relevant docs: https://www.notion.so/uniswaplabs/Limit-orders-kickoff-936d6300ef7844958851273babe89886
Screen.Recording.2023-11-14.at.2.39.53.PM.mov