feat: update default router preference in redux #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
mattbspector
approved these changes
Nov 13, 2023
Passing run #15510 ↗︎
Details:
Review all test suite changes for PR #7571 ↗︎ |
|||||||||||||||
|
once #7583 merges, these tests should pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
step 4 in the doc below, can be done independently of the migration or any code cleanup.
this change affects new users mostly - from now on they will have a persisted RouterPreference.X by default.
Linear ticket: https://linear.app/uniswap/issue/WEB-2788/uniswapx-opt-out-follow-up-migration
Relevant docs: https://www.notion.so/uniswaplabs/Web-UniswapX-Opt-Out-d7d5d33b3e2c447ab43d40cc92e427ae
Test plan
QA (ie manual testing)