Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a different ipfs gateway #7473

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: use a different ipfs gateway #7473

merged 1 commit into from
Oct 16, 2023

Conversation

just-toby
Copy link
Contributor

@just-toby just-toby commented Oct 16, 2023

Description

replaces the ipfs gateway url to cloudflare's. this should help us get around the ERR_CERT_COMMON_NAME_INVALID error that we were sometimes getting

Slack thread: https://uniswapteam.slack.com/archives/C047U65H422/p1697472005682969

Test plan

test that the new URL is successfully fetched, on the preview URL

image

@just-toby just-toby requested review from a team and zzmp October 16, 2023 18:22
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 6:24pm

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #7473 (90fb355) into main (f556f74) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 42.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 16, 2023

4 flaky tests on run #15043 ↗︎

0 118 0 0 Flakiness 4

Details:

fix: use a different ipfs gateway
Project: Uniswap Interface Commit: 90fb355910
Status: Passed Duration: 04:56 💡
Started: Oct 16, 2023 6:28 PM Ended: Oct 16, 2023 6:32 PM
Flakiness  uniswapx.test.ts • 3 flaky tests • e2e

View Output Video

Test Artifacts
UniswapX activity history > can view UniswapX order status progress in activity Output Screenshots
UniswapX activity history > deduplicates remote vs local uniswapx orders Output Screenshots
UniswapX activity history > balances should refetch after uniswapx swap Output Screenshots
Flakiness  swapFlowLogging.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
swap flow logging > completes two swaps and verifies the TTS logging for the first, plus all intermediate steps along the way Output Screenshots

Review all test suite changes for PR #7473 ↗︎

@just-toby just-toby merged commit c2440d1 into main Oct 16, 2023
@just-toby just-toby deleted the fix/ipfs-url branch October 16, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants