Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sitemap step from ci #7470

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

just-toby
Copy link
Contributor

Description

failing action: https://github.com/Uniswap/interface/actions/runs/6512256939/job/17689537081

the dependencies aren't installed in this CI action, so we can't rely on xml2js ? reverting now to unblock release and will follow up with a fix

@just-toby just-toby requested review from tinaszheng and a team October 13, 2023 19:51
@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 7:53pm

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #7470 (5df41fd) into main (cfaf5d7) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 42.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 13, 2023

4 flaky tests on run #15030 ↗︎

0 118 0 0 Flakiness 4

Details:

fix: remove sitemap step from ci
Project: Uniswap Interface Commit: 5df41fd07d
Status: Passed Duration: 04:39 💡
Started: Oct 13, 2023 8:13 PM Ended: Oct 13, 2023 8:18 PM
Flakiness  swap/uniswapx.test.ts • 3 flaky tests • e2e

View Output Video

Test Artifacts
UniswapX Orders > can swap exact-in trades using uniswapX Output Screenshots
UniswapX Orders > can swap exact-out trades using uniswapX Output Screenshots
UniswapX Orders > renders proper view if uniswapx order has insufficient funds Output Screenshots
Flakiness  permit2.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
Permit2 > prompts signature when existing permit approval amount is too low Output Screenshots

Review all test suite changes for PR #7470 ↗︎

@just-toby just-toby merged commit f556f74 into main Oct 13, 2023
@just-toby just-toby deleted the fix/remove-sitemap-from-ci branch October 13, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants