fix: specify canonical URLs #7455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
2 flaky tests on run #15009 ↗︎
Details:
|
|||||||||||||||
mattbspector
approved these changes
Oct 12, 2023
cbachmeier
reviewed
Oct 12, 2023
| @@ -35,8 +36,13 @@ if (window.ethereum) { | |||
| } | |||
|
|
|||
| function Updaters() { | |||
| const location = useLocation() | |||
There was a problem hiding this comment.
is there any issue with using a hook here?
There was a problem hiding this comment.
no, <Updaters /> is a child of <Router>. but let's switch just in case someone moves this code in the future
There was a problem hiding this comment.
sorry i spoke too soon ... when i tested without useLocation it breaks. because react-router handles navigations, window.location doesn't update the way we'd need it to
cbachmeier
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
declares the canonical for each page/route in the app in a way that removes query parameters, to better inform google.
right now, google is selecting the canonical automatically which is causing us to have a bunch of "not indexed" URLs - if we specify the canonical then google will know that this isn't an error and should just prioritize the URL we tell it to.
Linear ticket: https://linear.app/uniswap/issue/WEB-2789/seo-improvements
QA (ie manual testing)