Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bridge usdc arbitrum #7446

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

just-toby
Copy link
Contributor

Description

moonpay will no longer support bridged USDC on arbitrum, which means we don't have a reason to keep this token in the codebase anymore

Slack thread: https://uniswapteam.slack.com/archives/C047U65H422/p1697038790829849

@just-toby just-toby requested review from a team and cbachmeier October 11, 2023 16:10
@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview Oct 11, 2023 4:10pm

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #7446 (781cb85) into main (48855f4) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 42.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 11, 2023

4 flaky tests on run #14968 ↗︎

0 118 0 0 Flakiness 4

Details:

fix: remove bridge usdc arbitrum
Project: Uniswap Interface Commit: 781cb85c25
Status: Passed Duration: 05:34 💡
Started: Oct 11, 2023 4:16 PM Ended: Oct 11, 2023 4:22 PM
Flakiness  swap/uniswapx.test.ts • 3 flaky tests • e2e

View Output Video

Test Artifacts
UniswapX Orders > can swap exact-in trades using uniswapX Output Screenshots
UniswapX Orders > can swap exact-out trades using uniswapX Output Screenshots
UniswapX activity history > balances should refetch after uniswapx swap Output Screenshots
Flakiness  permit2.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
Permit2 > approval process (with intermediate screens) > swaps after completing full permit2 approval process Output Screenshots

Review all test suite changes for PR #7446 ↗︎

Copy link
Contributor

@kristiehuang kristiehuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanna make sure that whatever token list we use to pull arbitrum token info from is updated with the new Arbitrum native USDC

(wasn't the case with the Optimism/Base token list for Base native USDC, had to make PR on op's tokenlist repo to update)

@just-toby just-toby merged commit 40b1e40 into main Oct 11, 2023
@just-toby just-toby deleted the fix/remove-bridged-usdc-arb branch October 11, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants