feat: add robots.txt #7435
Merged
feat: add robots.txt #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-toby
requested review from
JackShort,
cbachmeier,
kristiehuang and
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
1 flaky test on run #14924 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| UniswapX Orders > renders proper view if uniswapx order has insufficient funds |
Output
Screenshots
|
|
Review all test suite changes for PR #7435 ↗︎
cbachmeier
approved these changes
Oct 6, 2023
kristiehuang
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a robots.txt file to tell the google crawler NOT to look at certain URLs. also, this helps it differentiate app.uniswap.org urls from top-level domain urls (uniswap.org)
to start, i'm adding a rule to disallow URLs like this:
https://app.uniswap.org/static/js/4.499580c4.chunk.js:2:1396910
since they're giving errors on the google search console
Linear ticket: https://linear.app/uniswap/issue/WEB-2860/add-a-robotstxt
test plan
tested with a robots.txt validator: https://technicalseo.com/tools/robots-txt/
it blocks the /static/js urls as intended and allows others