fix(governance): special case bravo parsing #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/6RyXkMFB5eMhvrwjasgbx756yYm6 |
|
I think that U+2018 and U+2026 codepoints were entered in reverse, and that that's why the parser fails. It seems to have failed parsing in https://www.withtally.com/governance/uniswap/proposal/8 as well (looking at the original description), and been updated for the displayed description. Do we know if/how this may have happened? |
Updates parseLog to delay parsing nested properties, so that they will only fail when accessed.
NoahZinsmeister
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace invalid UTF-8 characters in proposal descriptions with the replacement character to avoid crashes on future proposals with invalid UTF-8.
This is motivated by the Bravo proposal, which (1) has invalid characters, as U-2018 and U-2026 codepoints are reversed; and (2) omits newlines, preventing correct markdown parsing. This PR fixes the proposal programmatically instead of using a static constant (see e1f37b0) so that the data still originates on-chain, using guidance from ethers-io/ethers.js#1894.