-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
widgets: price fetching infinite hang #3212
Comments
@JFrankfurt Can I try tackling this? |
Go for it!
…On Fri, Feb 4, 2022, 4:42 PM alexanderlperez ***@***.***> wrote:
@JFrankfurt <https://github.com/JFrankfurt> Can I try tackling this?
—
Reply to this email directly, view it on GitHub
<#3212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMBRMQHFXLRHFKKVKA7MX3UZRI5VANCNFSM5NJNU2ZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks! @JFrankfurt Could you fill me in on some details? I'm running the stock repo locally, and I see the interface like so: The first thing I realize is that the UI looks different from the screenshot and that there is no hang in the UI recorded. Is there a different version of the UI pertaining to the bug? |
@alexanderlperez are you still working on this? If not, can I tackle this? |
Go on ahead!
…On Fri, May 12, 2023 at 1:17 PM Joshua DeCristi ***@***.***> wrote:
@alexanderlperez <https://github.com/alexanderlperez> are you still
working on this? If not, can I tackle this?
—
Reply to this email directly, view it on GitHub
<#3212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4DHIBXEPUYWTDENKPTRDTXF2EGFANCNFSM5NJNU2ZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@JFrankfurt This issue was solved in #6332 by showing "Insufficient liquidity for this trade." @just-toby can you confirm that this feature also fixed this issue? |
Bug Description
Steps to Reproduce
Expected Behavior
should fetch price/slippage for the trade
The text was updated successfully, but these errors were encountered: