Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widgets: price fetching infinite hang #3212

Open
JFrankfurt opened this issue Feb 1, 2022 · 6 comments
Open

widgets: price fetching infinite hang #3212

JFrankfurt opened this issue Feb 1, 2022 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers p0 Very important to fix widget

Comments

@JFrankfurt
Copy link
Contributor

Bug Description
image

Steps to Reproduce

  1. type a large # for input token
  2. click the switch in/output button
  3. price fetching hangs forever

Expected Behavior
should fetch price/slippage for the trade

@JFrankfurt JFrankfurt added bug Something isn't working good first issue Good for newcomers p0 Very important to fix widget labels Feb 1, 2022
@alexanderlperez
Copy link

@JFrankfurt Can I try tackling this?

@JFrankfurt
Copy link
Contributor Author

JFrankfurt commented Feb 4, 2022 via email

@alexanderlperez
Copy link

Thanks!

@JFrankfurt Could you fill me in on some details? I'm running the stock repo locally, and I see the interface like so:

uniswap-hang

The first thing I realize is that the UI looks different from the screenshot and that there is no hang in the UI recorded.

Is there a different version of the UI pertaining to the bug?

@Jdecristi
Copy link
Contributor

@alexanderlperez are you still working on this? If not, can I tackle this?

@alexanderlperez
Copy link

alexanderlperez commented May 13, 2023 via email

@Jdecristi
Copy link
Contributor

Jdecristi commented May 13, 2023

@JFrankfurt This issue was solved in #6332 by showing "Insufficient liquidity for this trade."

Screenshot 2023-05-13 at 3 43 51 PM

@just-toby can you confirm that this feature also fixed this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers p0 Very important to fix widget
Projects
None yet
Development

No branches or pull requests

3 participants