Skip to content

fix: optimize find command for better performance #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xwitty
Copy link

@0xwitty 0xwitty commented Feb 16, 2025

I noticed that the find command in the script was using -exec twice, which can be optimized. I replaced it with a single -exec using + to improve performance. Additionally, I cleaned up the backup file removal by using a separate find command.

Here's the updated code:

find "$TYPEDOC_OUTPUT_DIR" -type f -name "*.md" -exec \
  sed -i.bak -E 's/\\+//g' {} + && find "$TYPEDOC_OUTPUT_DIR" -type f -name "*.md.bak" -delete

This change should make the script more efficient while maintaining the same functionality.

Copy link

vercel bot commented Feb 16, 2025

@0xwitty is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant