Add cross-chain mappings to default token list #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteenm
force-pushed
the
matteen-tokenlist-crosschain
branch
from
2d7e6d2 to
c3f389d
Compare
JFrankfurt
suggested changes
Jun 10, 2022
src/write.js
Outdated
Comment on lines
1
to
5
| console.log(JSON.stringify(buildList(), null, 2)); | ||
|
|
||
| (async () => { | ||
| console.log(JSON.stringify(await buildList(), null, 2)); | ||
| })(); |
There was a problem hiding this comment.
I think you can skip the async iife like this:
buildList().then(data => console.log(JSON.stringify(data, null, 2)))
| module.exports = async function buildList() { | ||
| const parsed = version.split("."); | ||
| return { | ||
| const l1List = { |
There was a problem hiding this comment.
I don't think this needs to be an async function. Returning the chainify result (I'm assuming it's a promise?) will give you the same behavior.
package.json
Outdated
Comment on lines
37
to
39
| }, | ||
| "dependencies": { | ||
| "@uniswap/token-list-bridge-utils": "^1.0.7" |
package.json
Outdated
| "main": "build/uniswap-default.tokenlist.json", | ||
| "scripts": { | ||
| "test": "mocha", | ||
| "test": "mocha --timeout 10000", |
There was a problem hiding this comment.
It might make sense to manually provide the timeout where it's necessary (using this.timeout(n)) instead of setting it globally and potentially slowing down the whole suite.
matteenm
force-pushed
the
matteen-tokenlist-crosschain
branch
from
0f17fb6 to
0579450
Compare
JFrankfurt
approved these changes
Jun 10, 2022
JFrankfurt
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a call to the token-list-bridge-utils
chainifyfunction as part of the buildList.js script. This takes the generated L1 list and appends an extensions.bridgeInfo field to the token entries in the list which contains cross-chain address mapping information. The mappings will not be fully inclusive/complete, as we are limited to what the sources that token-list-bridge-utils uses provide.generated cross-chain token list file:
uniswap-default.tokenlist.txt