Skip to content

Conversation

@zhongeric
Copy link

@zhongeric zhongeric commented Mar 26, 2025

Pull Request

Description

Please include a summary of the change and which feature was implemented or which issue was fixed. Also, include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

Before deployment

  • 100% test and branch coverage
  • check slither for severe issues
  • fuzz and invariant tests (when applicable)
  • formal verification (when applicable)
  • deployment or upgrade scripts ready

After deployment

  • transfer ownership after deployments (when applicable)
  • complete upgrade (when applicable)
  • generate deployment/upgrade log files

Considerations

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run forge fmt and prettier to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional context

Add any other context about the pull request here.

@zhongeric zhongeric marked this pull request as draft March 26, 2025 15:53
Copy link
Collaborator

@gretzke gretzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can you install pre-commt (check CONTRIBUTING.md) to ensure formatting is correct and CI passes?
  • please merge main into this branch and use the DeployerHelper to deploy the contract, it ensures that reverting deploys are caught

@dianakocsis dianakocsis marked this pull request as ready for review April 30, 2025 19:44
@zhongeric zhongeric changed the title feat: deploy minimal delegation feat: deploy Caliburx May 9, 2025
@zhongeric zhongeric changed the title feat: deploy Caliburx feat: deploy Calibur May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants