Skip to content

Conversation

@stuparm
Copy link

@stuparm stuparm commented Jul 10, 2025

Pull Request

Description

This PR is a first one (probably out of two) that would enable the flow from github action:

  • create tenderly vnet
  • execute forge script
  • verify contracts
  • generate markdown

Third step verify contracts is not possible atm. Either foundry did some changes recently and it is not working, so verification flow did not start at all, or there is some configuration param stll missing. In any case I am getting the error
chain 1294121 not supported which is not the case with other vnets I tested so far.

This PR fixes the steps that are related to env variables produces by vnet-gh-action, by setting the values produced from Setup Tenderly Virtual TestNet step. Verification is removed from the job, so the goal is that we have job up and running.

My next task is to further investigate why verification is failing and then to enable it for this gh-action. It will be done in second PR

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

Before deployment

  • 100% test and branch coverage
  • check slither for severe issues
  • fuzz and invariant tests (when applicable)
  • formal verification (when applicable)
  • deployment or upgrade scripts ready

After deployment

  • transfer ownership after deployments (when applicable)
  • complete upgrade (when applicable)
  • generate deployment/upgrade log files

Considerations

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run forge fmt and prettier to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional context

Add any other context about the pull request here.

@gretzke gretzke changed the base branch from main to tenderly-fix July 10, 2025 13:39
@gretzke gretzke merged commit 1503ffd into Uniswap:tenderly-fix Jul 10, 2025
4 checks passed
@gretzke gretzke mentioned this pull request Jul 10, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants