fix: Correctly encode chainId attribute of EIP-712 messages #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chainIdattribute of the EIP-712 messages should be a number and not a string as specified on the spec:The latest ^5 version of EthersJs still parses the
chainIdattribute to a string (see code here) and this has only been fixed on the new ^6 version (see here).As these EIP-712 messages have the
chainIdset as string, the Wagmi library throws an error when trying to sign the typed message because "1" !== 1 (see signTypedData and assetActiveChain)Please consider having a look at this PR as I suppose that a migration to Ethersjs v6 is not coming soon 🙏🏻