audit(1): Missing min < max check #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Open
zhongeric
previously approved these changes
Oct 2, 2024
zhongeric
approved these changes
Oct 3, 2024
codyborn
reviewed
Oct 8, 2024
| @@ -34,6 +34,7 @@ library MathExt { | |||
| /// @param max The maximum bound for the result. | |||
| /// @return r The result of the bounded subtraction. | |||
| function boundedSub(uint256 a, int256 b, uint256 min, uint256 max) internal pure returns (uint256 r) { | |||
| require(min <= max, "MathExt: min must be less than or equal to max"); | |||
There was a problem hiding this comment.
I wonder if this is better to check in the SDK to save the additional gas.
There was a problem hiding this comment.
If we're going to keep it, we should switch to using a custom revert error:
https://www.notion.so/uniswaplabs/Protocols-Research-Team-Homepage-e55da9af622047b5b289b7b63e7d899e?pvs=4#b2048399e4664f6ebb1b6ddbec507a39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require that
boundedSubfollows the invariant of:min <= max