Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalidCosignature already defined in CosignerLib #277

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: invalidCosignature already defined in CosignerLib #277

merged 2 commits into from
Sep 25, 2024

Conversation

alanhwu
Copy link
Collaborator

@alanhwu alanhwu commented Sep 25, 2024

invalidCosignature() is never used as a revert in V3DutchOrderReactor.sol. It is already declared in CosignerLib where the revert based on cosignature occurs.

codyborn
codyborn approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@codyborn codyborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alanhwu alanhwu merged commit 062b516 into main Sep 25, 2024
3 checks passed
@codyborn codyborn deleted the fix-duplicate-error branch September 25, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyborn codyborn codyborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanhwu @codyborn