Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text about legal fees and outlays, and make set loan to max button clearer #36

Merged
merged 3 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions index.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Irish Mortgage Calculator</title>
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="/public/abacus.png" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Irish Mortgage Calculator</title>
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>
Binary file added public/abacus.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 5 additions & 2 deletions src/components/FeesPanel/FeesPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,17 @@ export const FeesPanel: React.FC<FeesPanelProps> = (props: FeesPanelProps) => {
style={{
fontWeight: "600",
fontSize: "1rem",
margin: "2rem 0 0 0",
marginTop: "2.5rem",
marginBottom: "0rem",
}}
>
Legal Fees and Outlays
</h2>

<Text variant="medium">
This is some text about legal fees and outlays.
An outlay is money spent by the solicitor on your behalf in
the conveyancing process e.g. land registry fees. Your legal
fees are your solicitor fees.
</Text>

<TextField
Expand Down
3 changes: 2 additions & 1 deletion src/components/MortgageComparison/MortgageComparison.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,9 @@ export const MortgageComparison: React.FC<MortgageComparisonProps> = () => {
<Text variant="medium">
If you found this useful, consider{" "}
<Link
target="_blank"
href="https://www.buymeacoffee.com/ryanlynch"
style={{ color: "rgb(33, 171, 56)" }}
target="_blank"
>
buying me a coffee! <Icon iconName="CoffeeScript" />{" "}
</Link>
Expand Down
43 changes: 30 additions & 13 deletions src/components/MortgageDetails/MortgageDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -123,23 +123,40 @@ export const MortgageDetails: React.FC<MortgageDetailsProps> = (
/>
</Stack.Item>

<Stack.Item grow>
<Stack.Item
grow
style={{
margin: "0.5rem 0 0 0",
}}
>
<Text variant="xxLarge">OR</Text>
</Stack.Item>

<Stack.Item
grow
style={{
margin: "0.5rem 0 0 0",
}}
>
<PrimaryButton
onClick={() =>
setLoanAmountToMax(houseValue, maxLoan, setLoanAmount)
}
>
Set loan to max
</PrimaryButton>{" "}
<TooltipHost
className="tooltip"
content="The maximum loan amount you can borrow is 90% of the house value, or the max loan amount you have set."
content="This is 90% of the house value, unless you have set a maximum loan amount above that is less than 90% of the house value. In that case, the maximum loan amount will be used."
directionalHint={5}
>
<PrimaryButton
onClick={() =>
setLoanAmountToMax(
houseValue,
maxLoan,
setLoanAmount
)
}
>
Set loan to max
</PrimaryButton>
<Icon
iconName="Info"
style={{
fontSize: "0.85rem",
color: "lightgreen",
}}
/>
</TooltipHost>
</Stack.Item>

Expand Down