Skip to content

Add Simen Abelsen to contributor lists #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lunkwill42
Copy link
Member

Scope and purpose

Simen's first PRs are being merged this week, so we should add him to the list of contributors :)

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • [ ] Added a changelog fragment for towncrier
  • [ ] Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • This pull request is based on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • [ ] If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • [ ] If this results in changes in the UI: Added screenshots of the before and after
  • [ ] If this adds a new Python source code file: Added the boilerplate header to that file

@lunkwill42 lunkwill42 requested a review from a team August 19, 2025 13:48
@lunkwill42 lunkwill42 self-assigned this Aug 19, 2025
@lunkwill42 lunkwill42 added documentation Related to documentation of NAV nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) labels Aug 19, 2025
Copy link

Copy link

Test results

   12 files     12 suites   12m 18s ⏱️
2 244 tests 2 244 ✅ 0 💤 0 ❌
6 297 runs  6 297 ✅ 0 💤 0 ❌

Results for commit f0f7245.

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.86%. Comparing base (854b0d8) to head (f0f7245).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3453   +/-   ##
=======================================
  Coverage   60.86%   60.86%           
=======================================
  Files         607      607           
  Lines       44309    44309           
  Branches       43       43           
=======================================
  Hits        26969    26969           
  Misses      17330    17330           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation of NAV nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant