Skip to content

Replace inlineCallbacks with coroutines in navoidverify.py #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

Fixes #3435. Copied from #3433.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • This pull request is based on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.

@johannaengland johannaengland requested review from lunkwill42 and a team August 13, 2025 13:40
@johannaengland johannaengland self-assigned this Aug 13, 2025
@johannaengland johannaengland added twisted cleanup nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) labels Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.96%. Comparing base (ae54b1f) to head (358d649).
⚠️ Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
python/nav/bin/navoidverify.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   60.93%   60.96%   +0.02%     
==========================================
  Files         607      607              
  Lines       44018    44017       -1     
  Branches       48       48              
==========================================
+ Hits        26822    26834      +12     
+ Misses      17184    17171      -13     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannaengland johannaengland force-pushed the cleanup/navoidverify-inlinecallbacks branch from 60bde3d to 358d649 Compare August 14, 2025 06:06
Copy link

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lunkwill42 lunkwill42 merged commit a9d1b5e into Uninett:master Aug 18, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) twisted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace usage of inlineCallbacks decorator in navoidverify.py with a coroutine
2 participants