-
Notifications
You must be signed in to change notification settings - Fork 42
Make it possible to switch between SVG and PNG QR codes #3414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to switch between SVG and PNG QR codes #3414
Conversation
d7d5a25 to
2ae2af8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3414 +/- ##
==========================================
+ Coverage 60.85% 60.86% +0.01%
==========================================
Files 608 608
Lines 44198 44237 +39
Branches 48 48
==========================================
+ Hits 26896 26927 +31
- Misses 17290 17298 +8
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't see any reason why this should still be labeled as blocked, so I removed it. |
2ae2af8 to
f23adeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Approving, despite the CodeCov report, since something is up with codecov now. It should greenlight the patch coverage as long as its above the global coverage (which means >60.91% should be ok in this case)
f23adeb to
0a7cffe
Compare
|



Scope and purpose
Closes #2916. Dependent on #2897 and #2899.
Adds a config option
qr_codes.file_formatthat gives the option to switch between generating QR codes as SVG or PNG files.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
we don't currently have any documentation for QR codes - should I add some? And if so, where?
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.