Add a devcontainer definition #3343
Draft
+162
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a base devcontainer image for Python code and adds some specializations for NAV. It also opts to add `uv` for Python environment management inside the devcontainer.
This defines the NAV devcontainer and PostgreSQL as separate services.
This tries to define an initial devcontainer for NAV development. This works for setting up and running NAV backend and front-end in the same container, but at the moment it leaves out Graphite.
lunkwill42
added
the
nonews
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
Test results 12 files 12 suites 12m 3s ⏱️ Results for commit d967e47. ♻️ This comment has been updated with latest results. |
|
With PyCharm, I am having the issue described in https://youtrack.jetbrains.com/issue/IJPL-174150 (I've voted for this issue to be fixed). I.e. every time I connect PyCharm to the devcontainer, I have to select a Python interpreter for the project to work (I want |
This script runs as the vscode user, not as root. Instead of trying to create a global upload dir where only root has access, this makes the upload directory in the main virtualenv and reconfigures the main `nav.conf` to point to that.
This lock file is produced by uv inside the devcontainer, but we don't (currently) want that file to be committed to git.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a devcontainer definition for NAV development.
The top-level
docker-compose.ymlconfiguration that we've had for quite a while is somewhat brittle, and integrates poorly into most IDEs, whereas devcontainers should integrate well into both VSCode and PyCharm (and command line tools exist for those who insist on using more old school editors as well).The hope is that this eventually can help every developer to obtain a more reproducible development environment for NAV.
The devcontainer definition is not yet fully complete (it still lacks a service definition for Graphite), so I'm leaving it in draft mode in the hopes that I can get some feedback on the work thus far.