Default to temporary directories with configurable output options #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this PR does not depend on Hashmap changes, it should just contain the tempfile commit (dd1d75c) and the first commit can be dropped. This enables PRs to be reviewed and merged independently from each other. |
chavic
force-pushed
the
chavic/test-generated-code-enhancement
branch
2 times, most recently
from
82e6f10 to
792ea82
Compare
spacebear21
previously requested changes
Aug 27, 2025
There was a problem hiding this comment.
There are now even more unrelated commits then before? To be clear this PR should just contain 792ea82
chavic
force-pushed
the
chavic/test-generated-code-enhancement
branch
from
cb9170e to
c1e8fc9
Compare
I'm not sure if the merge conflict had anything to do with it... I'll try again 🤔, though I remember fixing it... |
…put options - Use camino-tempfile::tempdir by default with automatic cleanup - Add TestConfig for full control over test execution - Support env overrides: UNIFFI_DART_TEST_DIR, UNIFFI_DART_NO_DELETE, UNIFFI_DART_FAILURE_DELAY - Resolve relative custom dirs against workspace root - Preserve temp files when no-delete is set (uses std::mem::forget) - Remove .tmp_tests references and folder - temp dirs are cleaner default Backwards compatible: existing run_test() continues to work.
chavic
force-pushed
the
chavic/test-generated-code-enhancement
branch
2 times, most recently
from
c1e8fc9 to
c3552f2
Compare
spacebear21
force-pushed
the
chavic/test-generated-code-enhancement
branch
from
c3552f2 to
3b01958
Compare
spacebear21
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatible: existing run_test() continues to work.