MNT: Improve logging set up #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manually adding a stream handler, use basicConfig(), which sets up a default formatter and stream handler. It also allows us to set a default logging level, which makes it easier for users to override.
jrleeman
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually adding a stream handler, use
basicConfig(), which sets up a default formatter and stream handler. It also allows us to set a default logging level, which makes it easier for users to override. It's not entirely the same as before, as we were setting different level for different modules. But at least in this case, user settings for logging will take precedence, regardless of whether they set it before or after they import siphon modules.