Update LICENSE and general maintenance #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
previously requested changes
Mar 27, 2018
There was a problem hiding this comment.
Oh that it were this easy. If you grep for "MIT" in the code base, you'll see so many more places that need updating.
I also think we should move to put the copyright with "Siphon Contributors" and add an AUTHORS.txt that includes UCAR.
All of that is why I was intending to wait for all other PRs to merge before biting this off.
dopplershift
force-pushed
the
license_change
branch
from
b4d1f96
to
0a80ab9
Compare
Also change copyright to just say "Siphon Contributors", and list all contributors in AUTHORS.txt, including UCAR/Unidata.
Otherwise it checks rst files generated by sphinx-gallery.
Need to turn on the version selector in the docs.
dopplershift
force-pushed
the
license_change
branch
from
a65f0f2
to
ec4990b
Compare
|
@lesserwhirls - Would you mind reviewing as I can't (and I presume Ryan can't) as authors? |
lesserwhirls
approved these changes
Mar 28, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now does a few things:
AUTHORS.txtdoc8before building docs, so that we don't check generated RSTconf.py