Port Iowa State Soundings from MetPy #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesserwhirls
previously approved these changes
Mar 20, 2018
|
@dopplershift had suggested looking into pandas json capabilities. Looking at the nested structure of the returned json (profiles -> (profile -> (temperature, etc), date, etc.)) the parsing appears to be less useful as nested data frames aren't a thing. Example of the json: http://mesonet.agron.iastate.edu/json/raob.py?ts=201012091200&station=BOI |
dopplershift
requested changes
Mar 20, 2018
siphon/simplewebservice/iastate.py
Outdated
|
|
||
| import warnings | ||
|
|
||
| from bs4 import BeautifulSoup |
|
Should have had the rebase in there, but I just fixed up a few flake things. |
dopplershift
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156 by porting the IA State upper air data functionality over from MetPy. Also fixes a typo in Wyoming and lack of test coverage there. I'll work on #189 for both Wyoming and Iowa after this.