TDS5 NCSS fixes #168
Merged
TDS5 NCSS fixes #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inclusion of the NCML namespace was breaking the parsing because ElementTree hands us tag names with the namespace included. Fix by stripping out the namespace, which seems to be the most common solution. Also take the opportunity to move handler lookup to _Types so that we don't make an external reference to _Types.__dict__ (Ew.)
jrleeman
suggested changes
Nov 3, 2017
| except ValueError: | ||
| log.warning('Cannot convert %s to int. Keeping type as str.', val) |
There was a problem hiding this comment.
Nope, logging is old-style only.
TDS is including a ',' as a separator in places, so optionally split on that.
dopplershift
force-pushed
the
tds5-fixes
branch
from
fb11c19
to
d33d8ad
Compare
|
Not exactly...I replaced |
It wasn't accomplishing anything (other than serving for `from siphon import *`). More importantly, it was actually incorrect by mentioning `upperair`.
|
Looks like the AppVeyor failure was transient. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some errors and a bunch of warnings in parsing the
dataset.xmlon a TDS 5.0 grib collection.