-
Notifications
You must be signed in to change notification settings - Fork 267
Skip cp314t for now and build cp314 on PRs #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fbd0584
to
12a5159
Compare
Not an HDF5 issue - it seems that numpy 2.3.2 is pickier about how it handles iterable slice indices. I will have a look. |
hmmm - not able to reproduce this on my mac with python 3.13.5 and numpy 2.3.2 |
If you update your fork from master, the tests should now pass on python 3.14 |
Looks like macos-12 is no longer supported, macos-13 is the only one that supports x86_64 |
ac2553d
to
c335f0d
Compare
Thanks! I updated that and it should be OK for a review now. PS: To make our lives easier in the future, note that these Linux builds are using the Docker images from https://github.com/ocefpaf/netcdf-manylinux/tree/35e29a405d74de914bfb9427bf4883eb9d4ced26. I did update to use a stable release of netcdf-c in the next build. Hopefully there won't be any significant changes. Also, we should really move that repo away from my personal account to make it easier for others to find and contribute. |
@jswhit do you think we should try |
I don't think the netcdf-c library is thread safe (there was some initial work done to fix this here, but it looks unfinished). Given this, maybe there is not much benefit? |
It is likely to fail too. I forgot about that. |
@jswhit I also had to update many of the dependencies in https://github.com/ocefpaf/netcdf-manylinux and the manylinux version to get this working with Python 3.14. The build is working now, but 2 tests are when excuted with the built wheel. Do you mind taking a look? I'm not sure I know where to start fixing them. Maybe downgrading hdf5?
Closes #1413