Add support for zstandard compression #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, figured it out. I didn't update the netCDF versions everywhere in the YML file... |
|
Looks good so far; I've got the |
|
Getting close to done here. Some things left to handle and test:
|
|
@WardF this is ready for merging. |
WardF
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350
This PR is a work in progress, which I am posting as a draft PR to take advantage of the GitHub CI.
This PR adds Zstandard to the F77 and F90 APIs, including tests.
The presence of Zstandard in the netcdf-c library is determined in the autotools/CMake build. The fortran functions return the NOTBUILT error if the user attempts to use Zstandard on a build where Zstandard was not found.
The tests require the zstandard filter to be in the HDF5_PLUGIN_PATH.