Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh318.wif #364

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Gh318.wif #364

merged 6 commits into from
Jun 23, 2022

Conversation

WardF
Copy link
Member

@WardF WardF commented Jun 22, 2022

This is #318 with conflicts resolved. I expect the tests will initially fail, as they currently rely on v4.8.1 as well as v4.9.0, and the reliance of this code on v4.9.0 features is part of how it got so tangled up.

@WardF WardF added this to the 4.6.0 milestone Jun 22, 2022
@WardF WardF self-assigned this Jun 22, 2022
@edwardhartnett
Copy link
Contributor

If you want this to work with versions of netcdf-c before 4.9.0, we can do that. We can even do it before the next netcdf-fortran release. Here's how I would approach that:
1 - merge this PR to get quantize in, turning off CI testing with any version other than 4.9.0.
2 - merge any other netcdf-fortran PRs that are desired.
3 - rename all files to F90 and F. This will cause the pre-procesor to be used.
4 - edit this code to guard it with pre-processor symbols.
5 - turn on CI testing for previous netcdf-c versions.

I'm happy to do this in the next few days. Let me know what you think...

@WardF
Copy link
Member Author

WardF commented Jun 23, 2022

@edwardhartnett That sounds good; getting the tests running to see what happens (not sure why they didn't run yesterday, probably the 'can't merge, there's a conflict'. The changes you outline would be great, and if you want to put up a PR it would be gratefully accepted. If not, I'll take a shot at it, although it will take a little bit of time. As it stands, just letting these tests run, wait for them to fail (as expected), make the change so that this then passes, and start merging the PR queue. Once that's done, we can rename to F90 and F, make the code changes, re-introduce previous versions of netCDF-C to the GitHub Actions.

@WardF WardF merged commit 90d23b6 into Unidata:main Jun 23, 2022
@WardF WardF deleted the gh318.wif branch June 23, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants