set 'CMAKE_POSITION_INDEPENDENT_CODE ON' for shared lib #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you, this is almost certainly the more correct way to do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving: geospace-code/nc4fortran#4
-fPICwas only set for APPLE or when using GNUCC compiler. In my case I ran into a linker error with Intel oneAPI on Ubuntu.I don't know if setting
CMAKE_POSITION_INDEPENDENT_CODE ONis to much, since I guess it will also affect the fortran tragets, so we could also only set thePOSITION_INDEPENDENT_CODEproperty for thenetcdff_ctarget.This could also solve #35