Attempt to correct an issue being observed under linux and OSX with gfortran #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this fix worked for us in Gentoo! |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jan 13, 2022
Drops Fortran flag workaround: Unidata/netcdf-fortran@846ec7a Bug: Unidata/netcdf-fortran#316 Bug: https://bugs.gentoo.org/723274 Signed-off-by: Sam James <sam@gentoo.org>
|
FFLAGS is used for F77 code, FCFLAGS for F90 code. Since netcdf-fortran contains both, we must always set both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
-fallow-argument-mismatchtoFFLAGSas adding it toFCFLAGSwas still resulting in failures when runningmake checkon linux and OSX.