Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nf-config using autotools #281

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Fix for nf-config using autotools #281

merged 2 commits into from
Oct 8, 2020

Conversation

mathomp4
Copy link
Contributor

@mathomp4 mathomp4 commented Oct 7, 2020

This PR is to restore the previous functionality of nf-config as detailed in #270.

Currently, building netcdf-fortran with autotools results in nf-config that returns:

-L/Users/mathomp4/NetcdfFortranFix/before/lib 
-lnetcdff

where you only get out the libnetcdff link, but not everything you need to link to netcdf-fortran.

Before 82273f8, nf-config --flibs returned something like:

-L/Users/mathomp4/NetcdfFortranFix/after/lib 
-lnetcdff -lnetcdf -lm 
-L/Users/mathomp4/NetcdfFortranFix/after/lib 
-L/Users/mathomp4/NetcdfFortranFix/after/lib 
-lnetcdf -ljpeg -lmfhdf -ldf -ljpeg -lhdf5_hl -lhdf5 -lm -lz 
-L/Users/mathomp4/NetcdfFortranFix/after/lib 
-lsz -ljpeg -ldl -lm

(which is what I get with this PR). This is essentially what you get from nc-config --libs appended to what's needed from netcdf-fortran

@WardF
Copy link
Member

WardF commented Oct 7, 2020

Thanks! Taking a look at the Travis-CI failure.

@WardF
Copy link
Member

WardF commented Oct 7, 2020

Ok, I need to tweak the travis config.

@mathomp4
Copy link
Contributor Author

mathomp4 commented Oct 7, 2020

Ok, I need to tweak the travis config.

Dang. Part of me was hoping I somehow managed to break the entire code by removing a single character! 😄

@WardF
Copy link
Member

WardF commented Oct 8, 2020

Ok, I need to tweak the travis config.

Dang. Part of me was hoping I somehow managed to break the entire code by removing a single character! 😄

I mean, have you seen 'Garfield without Garfield'? Sometimes removing a single character can have a profound impact ;).

@WardF
Copy link
Member

WardF commented Oct 8, 2020

Can you pull the latest master into your branch? That should resolve this. If not, I can pull your PR into a local branch and get the update travis config merged in that way.

@mathomp4
Copy link
Contributor Author

mathomp4 commented Oct 8, 2020

Can you pull the latest master into your branch? That should resolve this. If not, I can pull your PR into a local branch and get the update travis config merged in that way.

Okay. Just did:

  git remote add upstream https://github.com/Unidata/netcdf-fortran.git
  git remote update
  git merge upstream/master
  git push

which I think is right?

@WardF
Copy link
Member

WardF commented Oct 8, 2020

Yup! Thanks again!

@WardF WardF merged commit 2e15698 into Unidata:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants