Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct failure to compile on some mpi systems. #210

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Correct failure to compile on some mpi systems. #210

merged 4 commits into from
Jan 14, 2020

Conversation

WardF
Copy link
Member

@WardF WardF commented Jan 14, 2020 •
edited
Loading

Fixes #208

@WardF WardF added this to the 4.5.3 milestone Jan 14, 2020
@WardF WardF self-assigned this Jan 14, 2020
@WardF WardF merged commit b484440 into master Jan 14, 2020
@Dave-Allured Dave-Allured mentioned this pull request Jan 14, 2020
Closed
Dave-Allured
Dave-Allured reviewed Jan 15, 2020
View reviewed changes
Copy link

@Dave-Allured Dave-Allured left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the Github reference. There may be a different issue for MPI parallel, but it is not #208.

UPDATE: I am specifically referring to the #208 reference in the release notes.

Dave-Allured
Dave-Allured reviewed Jan 15, 2020
View reviewed changes
Copy link

@Dave-Allured Dave-Allured left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another suggested wording change for RELEASE_NOTES.md, to better clarify this fix. Also note one spelling fix.

From: Corrected an issue where parallel netCDF-Fortran builds would fail despite the presense of MPI libraries/compiler/infrastructure.

To: Corrected an issue where netCDF-Fortran builds for MPI parallel would fail despite the presence of MPI libraries/compiler/infrastructure.

@WardF WardF deleted the gh208.wif branch January 17, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dave-Allured Dave-Allured Dave-Allured left review comments

Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
4.5.3
Development

Successfully merging this pull request may close these issues.

Parallel build failures, netcdf-fortran 4.5.2
2 participants
@WardF @Dave-Allured