Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 64-bit integer memory type #190

Merged
merged 10 commits into from
Jul 2, 2019
Merged

Support 64-bit integer memory type #190

merged 10 commits into from
Jul 2, 2019

Conversation

wkliao
Copy link
Contributor

@wkliao wkliao commented Jun 26, 2019

This PR allows user programs to read/write 64-bit integer data of internal memory type (i.e. integer*8) to/from classic CDF NetCDF files. It was tested using the following NetCDF-C settings.

  • --disable-netcdf4 --disable-pnetcdf
  • --enable-netcdf4 --disable-pnetcdf
  • --disable-netcdf4 --enable-pnetcdf
  • --enable-netcdf4 --enable-pnetcdf

@edhartnett
Copy link
Contributor

Wait, does this capability exist in the C library?

@wkliao wkliao changed the title Support 64-bit integer memory type for classic CDF files Support 64-bit integer memory type Jun 26, 2019
@wkliao
Copy link
Contributor Author

wkliao commented Jun 26, 2019

In NetCDF-C header file, netcdf.h, such APIs have been defined. For example,

EXTERNL int
nc_put_vara_longlong(int ncid, int varid, const size_t *startp,
                  const size_t *countp, const long long *op);

@wkliao wkliao force-pushed the int64 branch 2 times, most recently from d0c2185 to 607c246 Compare June 26, 2019 20:04
@wkliao
Copy link
Contributor Author

wkliao commented Jun 26, 2019

I believe this PR also addresses issue #62
The newly added test program nf03_test/tst_fill_int64.F90 does the checking.

@WardF
Copy link
Member

WardF commented Jul 2, 2019

Thank you very much, this is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants