Use of "stop retval" is not portable

[wkliao]

When using gfortran 4.4.7, I got compile error message below.

Making check in nf_test4
Fortran/netcdf-fortran/nf_test4/ftst_groups.F:44.72:
         if (retval .ne. nf_noerr) stop retval                          
                                                                        1
Error: Syntax error in STOP statement at (1)

Fortran stop statement: STOP [str] where str is a
string of no more that 5 digits or a character constant.

[edhartnett]

gfortran 4.4.7 is pretty old. I am using 7.4.0.

Do we want to make this change just because of this very old fortran? I have not heard of any other problems with the stop statements.

Is it really not allowed by the fortran standard to do stop var, where var is an integer?

[wkliao]

Intel Fortran, ifort, version 17.0.2 gives the following error message.

error #6345: Either a PAUSE, STOP or ERROR STOP statement has an invalid argument.   [RETVAL]
         stop retval
--------------^

NAG Fortran Compiler 6.1.

NAG Fortran Compiler Release 6.1(Tozai) Build 6120
Error: RETVAL is not permitted in a constant expression
[NAG Fortran Compiler error termination, 1 error]

[WardF]

Unless this causes a problem with modern gfortran, I'm for incorporating it to support ifort and NAG. Thanks!