fix dependency tracking in fortran directory, enabling parallel (make -j) builds #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177.
In this PR I fix mod file dependency tacking.
I did this for the tests.mod file when re-doing the test directories. In this PR I do it for all the mod files in the fortran directory.
To reduce future confusion, I have renamed the (internal-only) mod file typeSizes to typesizes, matching the case of all the other mod files, and the case that gfortran and other fortran compilers want us to use for module names. This change will have no effect on user code.
With this PR, the .NOTPARALLEL directive is removed, and parallel (make -j) builds now work in all directories, demonstrating that all dependencies are being properly tracked.